fixed no content download bug

souvikinator · Mar 31, 2021 · 5717630 · 5717630
1 parent d4e04e0
commit 5717630
Show file tree

Hide file tree

Showing 4 changed files with 73 additions and 67 deletions.
diff --git a/README.md b/README.md
@@ -4,8 +4,14 @@ Nodejs module to download/retrieve a specific directory or sub-directory from a
 
 Any contribution is appreciated and please do report bugs if you find any.
 
+- **v1.0.2**: previous fix lead to bug, not downloading file contents. Fixed now
+
 - **v1.0.1**: fixed minor directory bug
 
+## Todo:
+
+- [] a bit slow! make it fast
+
 ## Installation
 
 ```js

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
  "name": "gh-retrieve",
- "version": "1.0.1",
+ "version": "1.0.2",
  "description": "Nodejs module to download/retrieve a specific directory from a GitHub repository",
  "main": "gh-retrieve.js",
  "dependencies": {

diff --git a/utils/helper.js b/utils/helper.js
@@ -32,9 +32,8 @@ exports.downloadFiles = async function (fileList, outdir) {
  let dirpath = path.join(outdir, filepath);
  // createParentDir(dirpath);
  let downloadUrl = fileList[filepath];
- fs.ensureFile(dirpath,async (err) => {
- if(err) throw new Error(err);
- await download(downloadUrl); 
- });
+ // create file before downloading
+ fs.ensureFileSync(dirpath);
+ fs.writeFile(dirpath, await download(downloadUrl));
  }
 }