Fix for [JENKINS-72181] -- Jenkins-cli groovy command does not return stdout and stderr (regression in 2.427) #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to fix JENKINS-72181, introduced in Jenkins version 2.427, we will have to add out.flush() so that we can print & get the slave jnlp secret
|
can you add your PR description to the CHANGELOG and I can release this, this afternoon. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to fix JENKINS-72181, introduced in Jenkins version 2.427, we will have to add
out.flush()so that the cookbook can print & get the slave jnlp secret correctly.Issues Resolved
With the latest Jenkins version 2.427 onwards, jenkins-cli groovy command does not return stdout and stderr. So cookbook was not able to get the slave jnlp secret correctly and was not able to register with the master.
This change should fix the issue.
Check List
## Unreleased