Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add v2 telemetry for ...usageLimitCta... events #4202

Merged
merged 13 commits into from
May 31, 2024

Conversation

akalia25
Copy link
Contributor

@akalia25 akalia25 commented May 17, 2024

This PR adds v2 telemetry for ...usageLimitCTA... events that were previously only being collected for V1 telemetry. In addition the createWebviewTelemetryRecorder function is being updated to accept either ApiPostMessage or VSCodeWrapper as parts of the codebase are using both, and this will simplify implementation.

Test plan

tested via chat-rateLimit.test.ts and ensured all v2 events are getting fired.

@akalia25 akalia25 marked this pull request as ready for review May 28, 2024 21:11
@akalia25 akalia25 requested a review from a team May 28, 2024 21:29
@akalia25 akalia25 merged commit fe3288e into main May 31, 2024
18 of 19 checks passed
@akalia25 akalia25 deleted the ak/add-v2-telemetry-to-usageLimitCta branch May 31, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants