Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# sample project #1248

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

TrevorDArcyEvans
Copy link

  • conversion of VB.NET sample to C#
  • factored out SolveSpace functionality to a separate file & namespace
  • C# project

@phkahler phkahler requested a review from ruevs May 24, 2022 14:24
@phkahler
Copy link
Member

Does this actually work? I never noticed the VB.NET one but C# seems like an even better idea.

@TrevorDArcyEvans
Copy link
Author

@phkahler Does it work? LOL! It definitely works ie outputs something to console and doesn't crash.

@@ -0,0 +1,369 @@
## Ignore Visual Studio temporary files, build results, and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding such a huge .gitignore seems like bad form to me. One that ignores only the specific files and directories created by VS when building the example is (in my opinion) better. Currently I do not have the C# build tools in my VS installation but I will add them (when I get to my development system) and try the example.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a 'standard' .gitignore from here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is clear from the comment at the top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants