merge latest from pterm/pterm
#1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns too many writers at once while testing. Windows tests should be enough, because there is not much different and those things that are different, are tested in the specific packages anyway.
docs(README): improved readme
…max-value-it-returns-the-first-and-not-the-last-color
… into 470-proposal-structured-logging
feat(logger): added pretty structured logger
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marvin Wendt <[email protected]> Co-authored-by: auntan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The latest version of pterm/pterm has
MultiPrinterstruct that we use in themeshctl x validate resourcescommand, but we can't use the latest pterm/pterm bc the race related PR that @josh-pritchard opened was never merged. These races show face when running meshctl e2e tests in CI.Scope
Related Issue
Fixes #
To-Do Checklist