glooctl get proxy: remove --proxy-ns and --all flags #9495
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the
--proxy-ns
and--all
flags that were added in #9226Previously, Proxies generated by the k8s gateway integration were saved in the same namespace as the Gateway and we didn't have a way to retrieve them with
glooctl get proxy
as it was only checking in the gloo install namespace. As the Proxies are now written to the writeNamespace (discoveryNamespace), we can derive the namespace from Settings instead of having the user pass it in via--proxy-ns
.The
--all
flag was useful when proxies could be generated in different namespaces, but now that they are all written to the writeNamespace, we can simplify the CLI by removing that flag.Other changes: print
proxy namespace
andcreated by
in the results table forglooctl get proxy
Testing steps
Manually verified that
glooctl get proxy
can get the proxies in the write namespace, without the proxy-ns flag. (Note: upcoming PRs will add e2e tests and fix the--edge
/--kube
filtering forglooctl get proxy
)Checklist: