Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glooctl get proxy: remove --proxy-ns and --all flags #9495

Merged
merged 6 commits into from
May 17, 2024

Conversation

jenshu
Copy link
Contributor

@jenshu jenshu commented May 16, 2024

Description

Remove the --proxy-ns and --all flags that were added in #9226

Previously, Proxies generated by the k8s gateway integration were saved in the same namespace as the Gateway and we didn't have a way to retrieve them with glooctl get proxy as it was only checking in the gloo install namespace. As the Proxies are now written to the writeNamespace (discoveryNamespace), we can derive the namespace from Settings instead of having the user pass it in via --proxy-ns.

The --all flag was useful when proxies could be generated in different namespaces, but now that they are all written to the writeNamespace, we can simplify the CLI by removing that flag.

Other changes: print proxy namespace and created by in the results table for glooctl get proxy

Testing steps

Manually verified that glooctl get proxy can get the proxies in the write namespace, without the proxy-ns flag. (Note: upcoming PRs will add e2e tests and fix the --edge / --kube filtering for glooctl get proxy)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@jenshu jenshu requested a review from a team as a code owner May 16, 2024 18:24
@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/6088

@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label May 16, 2024
Copy link

github-actions bot commented May 16, 2024

Visit the preview URL for this PR (updated for commit 07932bf):

https://gloo-edge--pr9495-glooctl-remove-proxy-m4arha7k.web.app

(expires Thu, 23 May 2024 21:28:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

nfuden
nfuden previously approved these changes May 16, 2024
sam-heilbron
sam-heilbron previously approved these changes May 16, 2024
projects/gloo/cli/pkg/common/proxy.go Show resolved Hide resolved
@jenshu jenshu added the work in progress signals bulldozer to keep pr open (don't auto-merge) label May 16, 2024
@jenshu jenshu changed the title glooctl get proxy: remove proxy-ns flag glooctl get proxy: remove --proxy-ns and --all flags May 16, 2024
@jenshu jenshu removed the work in progress signals bulldozer to keep pr open (don't auto-merge) label May 16, 2024
@soloio-bulldozer soloio-bulldozer bot merged commit 251a5d6 into main May 17, 2024
25 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the glooctl-remove-proxy-ns branch May 17, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants