Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Add select component #5363

Merged
merged 1 commit into from
Aug 31, 2023
Merged

[Admin] Add select component #5363

merged 1 commit into from
Aug 31, 2023

Conversation

waiting-for-dev
Copy link
Contributor

@waiting-for-dev waiting-for-dev commented Aug 30, 2023 •
edited

Summary

As with the other form components, it's design to be used along a Rails' form builder instance.

We need to use Javascript to style the select box differently when the prompt option is the one selected.

screenshot-localhost_3000-2023 08 31-06_21_13

Ref. #5329

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@waiting-for-dev waiting-for-dev requested a review from a team as a code owner August 30, 2023 14:17
@waiting-for-dev waiting-for-dev self-assigned this Aug 30, 2023
@waiting-for-dev waiting-for-dev added the type:enhancement Proposed or newly added feature label Aug 30, 2023
@waiting-for-dev
Add select component
86a540d 
As with the other form components, it's design to be used along a Rails'
form builder instance.

We need to use Javascript to style the select box differently when the
prompt option is the one selected.

Ref. solidusio#5329
@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/admin/select_box_component branch from 67f81ec to 86a540d Compare August 30, 2023 14:19
the-krg
the-krg approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@the-krg the-krg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Awesome! This will help me a lot on the roles page.

@waiting-for-dev waiting-for-dev merged commit 31813be into solidusio:nebulab/admin Aug 31, 2023
9 checks passed
@waiting-for-dev waiting-for-dev deleted the waiting-for-dev/admin/select_box_component branch August 31, 2023 08:30
waiting-for-dev added a commit to nebulab/solidus that referenced this pull request Sep 1, 2023
@waiting-for-dev
Fix parameter name in the select component
95e9c3c 
solidusio#5363 was merged just before
solidusio#5360, so it didn't pick up the
rename.
@waiting-for-dev waiting-for-dev mentioned this pull request Sep 1, 2023
Merged
3 tasks
elia pushed a commit that referenced this pull request Sep 25, 2023
@waiting-for-dev @elia
Fix parameter name in the select component
64bb72e 
#5363 was merged just before
#5360, so it didn't pick up the
rename.
elia pushed a commit that referenced this pull request Sep 27, 2023
@waiting-for-dev @elia
Fix parameter name in the select component
614e5ac 
#5363 was merged just before
#5360, so it didn't pick up the
rename.
elia pushed a commit that referenced this pull request Sep 28, 2023
@waiting-for-dev @elia
Fix parameter name in the select component
1e18d33 
#5363 was merged just before
#5360, so it didn't pick up the
rename.
elia pushed a commit that referenced this pull request Sep 28, 2023
@waiting-for-dev @elia
Fix parameter name in the select component
4955e2e 
#5363 was merged just before
#5360, so it didn't pick up the
rename.
elia pushed a commit that referenced this pull request Sep 29, 2023
@waiting-for-dev @elia
Fix parameter name in the select component
1f5df1e 
#5363 was merged just before
#5360, so it didn't pick up the
rename.
elia pushed a commit that referenced this pull request Oct 6, 2023
@waiting-for-dev @elia
Fix parameter name in the select component
12bbcb7 
#5363 was merged just before
#5360, so it didn't pick up the
rename.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-krg the-krg the-krg approved these changes

@rainerdema rainerdema Awaiting requested review from rainerdema

Assignees

@waiting-for-dev waiting-for-dev

Labels
changelog:solidus_admin type:enhancement Proposed or newly added feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@waiting-for-dev @the-krg