Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Extract product status component #5355

Conversation

waiting-for-dev
Copy link
Contributor

Summary

We'll need the same logic in the product forms, so we need to extract it to a component.

Ref. #5329

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • πŸ“– I have updated the README to account for my changes.
  • πŸ“‘ I have documented new code with YARD.
  • πŸ›£οΈ I have opened a PR to update the guides.
  • βœ… I have added automated tests to cover my changes.
  • πŸ“Έ I have attached screenshots to demo visual changes.

@waiting-for-dev waiting-for-dev requested a review from a team as a code owner August 21, 2023 10:21
@waiting-for-dev waiting-for-dev self-assigned this Aug 21, 2023
@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/admin/product_status_component branch from cc1aa8b to cb42030 Compare August 21, 2023 12:59
We'll need the same logic in the product forms, so we need to extract it
to a component.

Ref. solidusio#5329
@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/admin/product_status_component branch from cb42030 to f21466f Compare August 21, 2023 13:29
Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’―

@waiting-for-dev waiting-for-dev merged commit 872879b into solidusio:nebulab/admin Aug 22, 2023
9 checks passed
@waiting-for-dev waiting-for-dev deleted the waiting-for-dev/admin/product_status_component branch August 22, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants