Delmendo remove apt key #1039
Open
Delmendo remove apt key #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update install.sh - remove use of apt-key (apt-key is deprecated) [https://manpages.debian.org/testing/apt/apt-key.8.en.html#:~:text=DESCRIPTION,keys%20from%20the%20main%20keyring.] The preferred solution now is to download the key and attach it to the line in the apt sources file. This eliminates the following message when you update packages: W: https://gitsecret.jfrog.io/artifactory/git-secret-deb/dists/git-secret/InRelease: Key is stored in legacy trusted.gpg keyring (/etc/apt/trusted.gpg), see the DEPRECATION section in apt-key(8) for details. This follows the new guidelines. (Digital Ocean)[https://www.digitalocean.com/community/tutorials/how-to-handle-apt-key-and-add-apt-repository-deprecation-using-gpg-to-add-external-repositories-on-ubuntu-22-04] This is based on example from (Helm)[https://helm.sh/docs/intro/install/]
Removing line that was duplicated.
Added in a note to the changelong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
The Debian instructions use apt-key which has been deprecated. Using the existing directions causes a deprecation warning on every package update. I re-wrote them to use the modern path - this removes the error and installs the pacakge.
Does this close any currently open issues?
…
Any relevant logs, error output, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Any other comments?
…