Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MaxResults parameter to SQS ListQueuesInput #1651

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Prajithp
Copy link

@Prajithp Prajithp commented Apr 10, 2023

Q A
πŸ› Bug fix? yes
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #...
❓ Documentation no

Description

If more than 1000 sqs are there in an account, the ListQueuesPages returns only 1000 results if we don't specify the MaxResults parameter. This PR will list only 100 queues per pages and go till the lastPage.
Reference: https://docs.aws.amazon.com/sdk-for-go/api/service/sqs/#ListQueuesInput

@Prajithp Prajithp requested a review from a team as a code owner April 10, 2023 11:33
@Prajithp Prajithp requested review from wbeuil and removed request for a team April 10, 2023 11:33
@CLAassistant
Copy link

CLAassistant commented Apr 10, 2023

CLA assistant check
All committers have signed the CLA.

@Prajithp Prajithp changed the title add MaxResults ListQueuesInput add MaxResults parameter to SQS ListQueuesInput Apr 10, 2023
@arunclear
Copy link

Can we get an update on this? We're still facing this issue. Driftctl reports all of the SQS queues as missing resources.

@Prajithp
Copy link
Author

Any update on this?

@Prajithp Prajithp requested a review from a team as a code owner August 10, 2023 12:29
@Prajithp Prajithp requested review from rontalx and removed request for wbeuil and a team August 10, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants