Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --service for running as a windows service for renewal and rekeying #877

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

unreality
Copy link
Contributor

Name of feature:

Adds a new command line flag --service which will run as a Windows Service. Users can install the service by running sc.exe create step-renew binPath= "path_to_step_cli.exe ca renew --service --ca-url=the_ca_url --root=path_to_root_ca.crt certfile.crt keyfile.key as an Administrator.

Pain or issue this feature alleviates:

Allows renewal via windows service as an alternative to --daemon on windows hosts

Why is this important to the project (if not answered above):

Is there documentation on how to use this feature? If so, where?

CLI usage examples have been added

In what environments or workflows is this feature supported?

Windows hosts

In what environments or workflows is this feature explicitly NOT supported (if any)?

Non-windows hosts (use --daemon instead)

Supporting links/other PRs/issues:

馃挃Thank you!

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Mar 10, 2023
@maraino
Copy link
Collaborator

maraino commented Mar 10, 2023

I suppose we can also add OS custom flags of files that use go tags.

#go:build windows

package ca

import "..."

func rekeyExtraFlags() []cli.Flag {
    return []cli.Flag
        cli.BoolFlag{Name: "service", Usage: "..."},
    }
}

The problem with adding this is that we cannot keep the order, but those flags won't appear on other OSs.

@dopey dopey requested a review from hslatman March 15, 2023 17:05
@maraino maraino modified the milestones: v0.24.0, v0.24.1 Apr 12, 2023
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Raal Goff seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@maraino maraino modified the milestones: v0.24.4, v0.24.5 Jul 18, 2023
@maraino maraino modified the milestones: v0.25.0, v0.25.1 Sep 27, 2023
@hslatman hslatman modified the milestones: v0.25.1, v0.25.2 Nov 29, 2023
@hslatman hslatman modified the milestones: v0.25.2, v0.25.3 Feb 20, 2024
@hslatman hslatman modified the milestones: v0.26.0, v0.26.1 Mar 29, 2024
@hslatman hslatman modified the milestones: v0.26.1, v0.26.2 Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants