live-preview: Add a button into the Component List to add a new component and to switch over to it #5155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a button to add a new component and trigger a callback on the rust side.
tronical
reviewed
Apr 30, 2024
| font-weight: 800; | ||
| } | ||
| Button { | ||
| text: "+"; |
There was a problem hiding this comment.
Please add a label, not just an icon (which is what the + is).
https://uxmyths.com/post/715009009/myth-icons-enhance-usability
An alternative pattern is a new edit that acts as name entry and action button when accepted is invoked (that’s what we should use in our property editor).
There was a problem hiding this comment.
I do not plan to use this as is. The UI is a bit clunky and we need some more features e.g. a way to export and rename the newly added component as well as show which component is currently displayed and why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this functionality, but I do not want it in the upcoming release: It is pretty confusing that it switches to a different component -- which hides all the current work!
We need to have some information in the current component in preview on screen for that to be less surprising and offer a way to get back to the "main preview" somehow.