C++: if a SLINT_SCALE_FACTOR is set at compile time, default to that #5016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronical
approved these changes
Apr 4, 2024
| // ESP_LOGI(TAG, "x: %i, y: %i", touchpad_x[0], touchpad_y[0]); | ||
| last_touch_x = touchpad_x[0]; | ||
| last_touch_y = touchpad_y[0]; | ||
| last_touch_x = float(touchpad_x[0]) / scale_factor; |
| @@ -185,6 +185,14 @@ pub unsafe extern "C" fn slint_window_adapter_new( | |||
| set_position, | |||
| }); | |||
|
|
|||
| if let Some(scale_factor) = | |||
| option_env!("SLINT_SCALE_FACTOR").and_then(|x| x.parse::<f32>().ok()).filter(|f| *f > 0.) | |||
There was a problem hiding this comment.
Isn't that a little dangerous for regular C++ users? Or is it safe because it'll be overridden anyway later when a windowing system is used?
I guess ideally this would be a cmake cache variable that - if set - maps to an environment variable set for corrosion to pass to cargo. Maybe the cache variable could still be called SLINT_SCALE_FACTOR but the environment variable would be CMAKE_SLINT_SCALE_FACTOR.
There was a problem hiding this comment.
If the C++ programmer set a C++ scale factor at runtime, it will be overridden.
But you're right that this probably should be a cmake setting rather than a env variable.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.