Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler panic when using % size in a flickable #4223

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix compiler panic when using % size in a flickable #4223

wants to merge 2 commits into from

Commits on Dec 27, 2023

  1. Fix compiler panic when using % size in a flickable 

    The viewport of a flickable is of ElementType::Native, and `lookup_property`
don't query the builtin reserved properties in that case.

This commit fix the assert by allowing Type::Invalid as well.

Fixes #4163
    @ogoffart
    ogoffart committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    bf70d80 View commit details
    Browse the repository at this point in the history

  2. Update tests/cases/issues/issue_4163_flickable_parent_percent.slint 

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    @ogoffart @github-actions
    ogoffart and github-actions[bot] committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    b1c499d View commit details
    Browse the repository at this point in the history