Detect binding loops that applies to the Window itself #3997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronical
approved these changes
Nov 23, 2023
|
Maybe “dingind” -> “binding” :) |
ogoffart
changed the title
|
What is status of this PR? I have random crashes related to logic bugs same as in linked issues, but when looking at CI I see that there are some regressions(or expected api breakage) |
|
Yes, there is some API breakage and we're not confident we can do them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Window geometry depends on its constraints, so its constraints cannot depends on its geometry
This fixes Infinitely growing layout, and other panics
Fixes #3989
Fixes #2902