Fix panic when code in init callback of conditional/repeater re-triggers repeater traversal #3215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
approved these changes
Aug 4, 2023
| let mut inner = self.0.inner.borrow_mut(); | ||
| inner.components.resize_with(count, || (RepeatedComponentState::Dirty, None)); | ||
| let offset = inner.offset; | ||
| let mut any_items_created = false; | ||
| for (i, c) in inner.components.iter_mut().enumerate() { | ||
| if c.0 == RepeatedComponentState::Dirty { | ||
| let created = if c.1.is_none() { | ||
| if c.1.is_none() { | ||
| any_items_created = true; | ||
| c.1 = Some(init()); |
There was a problem hiding this comment.
Can't this call to init() also recurse?
There was a problem hiding this comment.
Yes, true, there's probably a way of doing that.
There was a problem hiding this comment.
i think just by adding another layer:
// added if true there:
if true: layout := VerticalLayout {
if true: TextInput {
// Trigger a call into the layout
init => { debug(self.y); }
}
}
But maybe self.y don't cross layers, but some other properties certainly will
There was a problem hiding this comment.
I wonder how to fix this. I mean, I made a local change to separate out the init() creation without borrowing the inner, but conceptually this would still recurse because the dirty() flag is true.
Perhaps like this?
- Replace inner.components with an empty vec; set dirty to false.
- Update any dirty components, call init, etc() - during that time any recursion will find an empty repeater.
- Replace inner.components with the updated vec.
There was a problem hiding this comment.
Maybe keep a Vec of ItemTreeRc and init them when the RefCell is not borrowed?
tronical
force-pushed
the
simon/model-delay-init
branch
from
b46477e
to
d4028f6
Compare
|
(just a rebase for now) |
…ers repeater traversal Don't call init() while mutably borrowing the repeater's inner. Fixes #3214
tronical
force-pushed
the
simon/model-delay-init
branch
from
d4028f6
to
c2c2294
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't call init() while mutably borrowing the repeater's inner.
Fixes #3214