extra_perimeters : now add perimeters for overhangs. #4717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Build Slic3r 1.3.0-master-2255 failed (commit c237560fb3 by @) |
supermerill
force-pushed
the
overhang_perimeters
branch
from
46ab17d
to
c426081
Compare
|
❌ Build Slic3r 1.3.0-master-2256 failed (commit bdbd5d93fa by @) |
supermerill
force-pushed
the
overhang_perimeters
branch
3 times, most recently
from
258da5b
to
63721fb
Compare
|
❌ Build Slic3r 1.3.0-master-2259 failed (commit 52f2ba58ab by @) |
…ngs are detected. extra_perimeters: Use CW instead of CCW every odd layers for overhangs.
supermerill
force-pushed
the
overhang_perimeters
branch
from
63721fb
to
13c6ba8
Compare
|
❌ Build Slic3r 1.3.0-master-2260 failed (commit 6d66c5c3f4 by @) |
|
Extra perimeters triggers on some slopes, where otherwise you would see infill |
|
could you tell me the file and the lines? I tried to search each call to the setting but maybe i forgot some files in my search. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extra_perimeters: now also add extra perimeters if infill-over-overhangs are detected.
extra_perimeters: Use CW instead of CCW every odd layers for overhangs.
pic: https://github.com/supermerill/Slic3r/wiki/Extra-perimeters-if-needed-:-overhangs
also, like in slic3rPE, i can't see where the parameter 'extra_perimeters' do something. It's a fake setting?
note: currently building & debugging, please wait a bit before review.