Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Error out for null env var #3557

Merged
merged 13 commits into from
May 16, 2024
Merged

[UX] Error out for null env var #3557

merged 13 commits into from
May 16, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented May 16, 2024

When an env var is specified in YAML but is empty, sky launch without --env will fail.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • sky launch llm/llama-3/llama3.yaml correctly fail
    • sky launch llm/llama-3/llama3.yaml --env HF_TOKEN works.
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@Michaelvll Michaelvll requested review from cblmemo, concretevitamin and romilbhardwaj and removed request for cblmemo May 16, 2024 05:38
@Michaelvll Michaelvll added the P0 label May 16, 2024
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Michaelvll! Works nicely!

sky/task.py Outdated Show resolved Hide resolved
sky/task.py Outdated Show resolved Hide resolved
@Michaelvll Michaelvll merged commit eae8fc5 into master May 16, 2024
20 checks passed
@Michaelvll Michaelvll deleted the disable-null-env-var branch May 16, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants