Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Support --skip-failed/-s to skip failed replica in sky serve status CLI #3548

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented May 14, 2024

Closes #3547 .

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
(sky) ➜  skypilot git:(serve-skip-failed) ✗ ssst   
Services
NAME  VERSION  UPTIME  STATUS      REPLICAS  ENDPOINT                                                                  
fail  -        -       NO_REPLICA  0/0       http://localhost:30072/skypilot/sky-serve-controller-402b1bba-402b/30001  

Service Replicas
SERVICE_NAME  ID  VERSION  ENDPOINT  LAUNCHED  RESOURCES  STATUS                REGION  
fail          1   1        -         -         -          FAILED_INITIAL_DELAY  -       
(sky) ➜  skypilot git:(serve-skip-failed) ✗ ssst -s
Services
NAME  VERSION  UPTIME  STATUS      REPLICAS  ENDPOINT                                                                  
fail  -        -       NO_REPLICA  0/0       http://localhost:30072/skypilot/sky-serve-controller-402b1bba-402b/30001  

Service Replicas
No existing replicas.
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@cblmemo cblmemo changed the title [WIP][Serve] Support --skip-failed/-s to skip failed replica in sky serve status CLI [Serve] Support --skip-failed/-s to skip failed replica in sky serve status CLI May 14, 2024
@cblmemo cblmemo marked this pull request as ready for review May 14, 2024 13:03
@cblmemo
Copy link
Collaborator Author

cblmemo commented May 14, 2024

To discuss: Should we skip the failed replicas in the service table shown by sky status as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Serve] Support skip failed replica in CLI
1 participant