[k8s] Optimize service creation #3446
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
reviewed
Apr 25, 2024
| @@ -96,7 +99,10 @@ provider: | |||
| - protocol: TCP | |||
| port: 22 | |||
| targetPort: 22 | |||
| {% endif %} | |||
| {% if num_nodes > 1 %} | |||
There was a problem hiding this comment.
Just curious, why is the following service ever required? It seems 8265 or 10001 does not need to be exposed to public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes our Kubernetes service creation to create services only when required. Reduces SkyPilot's footprint on the k8s cluster.
-head-sshservice - required only when using NodePort networking mode-headservice- required only when using multi-nodeBased on feedback from user.
Tested - manually with
sky launchon multi-node and single node clusters.