[ENH] Drop numpy array input support #831
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if we don't have time to merge this before the release maybe we should at least remove mentions of ndarrays from the tablevectorizer docstring |
|
I'll create a PR for that today, thanks |
|
I was going to do it but I thought it would just introduce conflicts with the current tablevectorizer PR
|
|
Nevermind, let's release first. We'll deal with this with the two follow-up PRs for TableVectorizer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
Addresses #830
Follows-up on #819 (after #819 is merged, the differences of this PR will reduce significantly)
What does this PR implement
Raise an error when the input
Xdoesn't have an__dataframe__attribute (supported from Pandas version 1.5.3, our minimum supported version).