Respawn Pure async worker on crash #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 13, 2020
wezzynl
added a commit
to wezzynl/pure
that referenced
this pull request
May 1, 2020
* upstream/master: 1.12.0 Respawn Pure async worker on crash (sindresorhus#543) Use HTTPS links Fix stash during git action (sindresorhus#535) Move Git action after dirty with space and default color (sindresorhus#506)
wezzynl
added a commit
to wezzynl/pure
that referenced
this pull request
Sep 28, 2020
…ster * 'master' of https://github.com/sindresorhus/pure: 1.14.0 More system report improvements (sindresorhus#568) Use GIT_OPTIONAL_LOCKS=0 instead of --no-optional-locks (sindresorhus#569) Show user@host when running in a container (sindresorhus#564) Update zsh-async to v1.8.4 (sindresorhus#566) Add zsh-async version to system report (sindresorhus#567) Bump Pure internal version when publishing package (sindresorhus#565) Update readme.md 1.13.0 Respect Git config `status.showUntrackedFiles` (sindresorhus#542) Add forivall/pure to Ports section in the readme (sindresorhus#556) Fix '--no-optional-locks' argument position (sindresorhus#553) Eliminate unnecessary Git locking (sindresorhus#549) Readme tweaks 1.12.0 Respawn Pure async worker on crash (sindresorhus#543) Use HTTPS links Fix stash during git action (sindresorhus#535) Move Git action after dirty with space and default color (sindresorhus#506)
kutsan
pushed a commit
to kutsan/pure
that referenced
this pull request
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns Pure into a phoenix bird! Or well, close enough.
The zsh-async lib is now capable of detecting worker "crashes" and notifying Pure, giving it a chance to relaunch the worker and restart async tasks.
Fixes #455
Fixes #523
There's also a small chance that the async updates amend the issue in #502 (issue being 99% CPU usage). Although there still seems to be a very small chance of rogue Zsh processes sticking around (but their CPU usage seems to be 0%.)
IssueHunt Summary
Referenced issues
This pull request has been submitted to: