Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #101

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Upgrade dependencies #101

merged 1 commit into from
Jan 21, 2020

Conversation

joelpurra
Copy link
Contributor

Attempts to fix linter parsing issues stemming from changes in typescript v3.7.

  • Upgrade eslint-related packages.
  • Upgrade typescript and related tsconfig.
  • Fixes linting errors due to upgraded rules.
  • Note that you might need to remove node_modules and run npm install again to properly clear linting caches.
  • Include the test directory in the typescript project to fix the below parsing error.

Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: test/test.ts.
The file must be included in at least one of the projects provided.

See

tsconfig.json Outdated Show resolved Hide resolved
Attempts to fix linter parsing issues stemming from changes in typescript v3.7.

- Upgrade `eslint`-related packages.
- Upgrade `typescript` and related `@sindresorhus/tsconfig`.
- Fixes linting errors due to upgraded rules.
- Note that you might need to remove `node_modules` and run `npm install` again to properly clear linting caches.
- Include the `test` directory in a separate `tsconfig.xo.json` to fix the below parsing error.

> Parsing error: `"parserOptions.project"` has been set for `@typescript-eslint/parser`.
> The file does not match your project config: `test/test.ts`.
> The file must be included in at least one of the projects provided.

See

- typescript-eslint/typescript-eslint#1045
- https://github.com/microsoft/TypeScript/commits/v3.7.5
- sindresorhus/tsconfig#7
- xojs/eslint-config-xo-typescript#20
- xojs/eslint-config-xo-typescript#15
@sindresorhus sindresorhus changed the title Upgrade typescript- and linting-dependencies Upgrade dependencies Jan 21, 2020
@sindresorhus sindresorhus merged commit c842cc2 into sindresorhus:master Jan 21, 2020
@sindresorhus
Copy link
Owner

Thanks for doing this 👌

@joelpurra joelpurra deleted the upgrade-typescript-linting branch January 21, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants