lint awesome with awesome-lint as an Action #1675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| id: checkout | ||
| uses: actions/checkout@v2 | ||
| - name: awesome-lint-action | ||
| uses: squadcastHQ/awesome-lint-action@master |
There was a problem hiding this comment.
I don't really see why you need a custom workflow for this. You could just run $ awesome-lint as a command.
alexesprit
reviewed
Jan 19, 2020
| @@ -0,0 +1,20 @@ | |||
| on: [push, pull_request] | |||
There was a problem hiding this comment.
This could be changed to:
on:
push:
# Run against master branch only
branches: [master]
pull_request:
# Include events emitted on code change only
types: [opened, synchronize]
Merged
|
I decided to rename |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an Action for linting with
awesome-lintwhen opening PRs into awesome so that linting issues could be addressed earlier. Addresses #1365.馃枛 I have read through the requirements multiple times. I believe it satisfies all of the requirements.