Fix for freezes in MenuBarExtra and NavigationStack #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Jan 18, 2024
|
|
||
| var value: Value { | ||
| get { Defaults[key] } | ||
| set { | ||
| objectWillChange.send() |
There was a problem hiding this comment.
I don't see any harm in keeping this? Unless I'm missing something. See: #144 (comment)
There was a problem hiding this comment.
If that is kept, the menubar will still freeze for some reason. Removing it fixes that, and doesn't seem to affect anything
There was a problem hiding this comment.
@Wouter01 Removing objectWillChange.send() broke animations when using withAnimation, so I will have to add it back unless you can think of a better solution.
Reproduction: Fixture.zip
sindresorhus
approved these changes
Jan 18, 2024
hank121314
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the internal code of the
@Defaultproperty wrapper, so it uses StateObject instead of ObservableObject. This fixes #144As StateObject is not supported in SwiftUI 1.0, an
@availablehas been added. This could be a breaking change for projects with the minimum target set to iOS 13.0 etc.Instead of creating a new model when the key changes (which is what happened previously), the key will now be changed in the model itself. An extra check is done to make sure that the observers are not restarted too often.