Fixes infinite recursion when casting AnySerializable to wrong type
#147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a values associated type `Serializable` , equals the values type, `toValue` would infinitely call itself. The test `testWrongCast` reproduces this and I fixed it by comparing the `nextType` with the current type.
hank121314
requested changes
Sep 2, 2023
Sources/Defaults/Utilities.swift
Outdated
| @@ -194,7 +194,7 @@ extension Defaults.Serializable { | |||
| return anyObject | |||
| } | |||
|
|
|||
| guard let nextType = T.Serializable.self as? any Defaults.Serializable.Type else { | |||
| guard let nextType = T.Serializable.self as? any Defaults.Serializable.Type, nextType != T.self else { | |||
There was a problem hiding this comment.
Please fix the indention, we are using tab indention.
There was a problem hiding this comment.
Fixed that. Sorry about that.
Comment on lines
470
to
474
| func testWrongCast() { | ||
| let value = Defaults.AnySerializable(false) | ||
| XCTAssertEqual(value.get(Bool.self), false) | ||
| XCTAssertNil(value.get(String.self)) | ||
| } |
There was a problem hiding this comment.
Same as the above comment, and please use XCTAssertFalse instead of XCTAssertEqual as linter suggests.
There was a problem hiding this comment.
I initially used that, but since get returns on optional, I'd have to provide a default value. That feels less clean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a values associated type
Serializable, equals the values type,toValuewould infinitely call itself.The test
testWrongCastreproduces this and I fixed it by comparing thenextTypewith the current type.