Add 'release bilateral attributes' feature to AttributeLimit authproc #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sitya! Thanks a lot for the PR! After a very, very quick glance at it, it looks great. I'll take a deeper look at it as soon as I can and hopefully merge it 😉 |
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
1c686ab
to
eb20457
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
08ebb9c
to
64fca25
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
7a53fc8
to
d73ae47
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
e5c0e21
to
d5616df
Compare
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
2e6ab04
to
32f9acc
Compare
tvdijen
force-pushed
the
master
branch
6 times, most recently
from
7e3ea19
to
2523634
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
aa168f3
to
504b555
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
29f7b69
to
1a911ce
Compare
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
c7c8357
to
fdbe001
Compare
tvdijen
force-pushed
the
master
branch
8 times, most recently
from
3b5f5ba
to
96357ee
Compare
tvdijen
force-pushed
the
master
branch
5 times, most recently
from
7587851
to
d523b31
Compare
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
8c90121
to
d534e3b
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
bc1c5c8
to
d0a5974
Compare
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
ccb9b02
to
120a100
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
6004a77
to
58bf8db
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
5c9fb2c
to
0970efc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AttributeLimit allows to release only that attributes to the SP, which are listed in SP's metadata. In the most federation metadata is generated by a central tool of the national federation, so there could be attributes which are not specified in the federation (so it could not be listed in SP's requiredAttributes), but the SP would need it.
With this PullRequest we implemented this feature. It adds the functionality of specifying bilateral attribute relations in addition to the attribute rules defined in the peer's metadata. You can both specify SP entityIDs where you send some additional attributes (bilateralSPs) and special attributes to send to some SPs (bilateralAttributes).