Replace Locator and Content\Type\Sniffer with Content\Detector #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use Detector in SimplePie class
This was referenced Sep 13, 2023
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #731 we plan to deprecate the
SimplePie\Fileclass. The file class is required forSimplePie\LocatorandSimplePie\Content\Type\Sniffer, so the plan is to deprecate this classes too. See also the discussion in #826 (comment)This PR introduces a new interface
SimplePie\Content\Detectorthat defines the most features of the Locator and Sniffer in 3 methods.The
SimplePie\Content\VerfiedFeedsDetectorclass was created for BC. It internally uses the old Locator and Sniffer classes. This is needed because Locator and Sniffer classes could be replaced by the user using the Registry.A new
SimplePie\Content\UnverfiedFeedsDetectorhas to be created to replace the function of Locator and Sniffer. The idea is that this Detector should not have a dependency to a HTTP client but should only work withResponseclasses.This PR is under construction and requires some other PRs like #838 and a refactoring of the microformats handling in
SimplePie\SimplePie::fetch_data()