Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop legacy file cache constantly updating #846

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Stop legacy file cache constantly updating #846

wants to merge 4 commits into from

Conversation

Art4
Copy link
Contributor

@Art4 Art4 commented Aug 28, 2023

This PR fixes a bug introduced in #752.

Fixes #830.

@Art4 Art4 mentioned this pull request Aug 28, 2023
Open
@Art4
Copy link
Contributor Author

Art4 commented Aug 28, 2023

Something very strange is going on here. Builds 606 and 608 are for the exact same code changes but the results for different PHP versions is different.

grafik

I can not reproduce this on my machine (tests are successfully on PHP 8.2). I assume some race conditions on the Github Actions?

@Art4 Art4 marked this pull request as draft August 28, 2023 12:21
@Art4
Copy link
Contributor Author

Art4 commented Aug 28, 2023

I can reproduce this strange behavior on my GitHub fork: I have rerun the job for the same commit 4 times and got randomly different errors each time.

grafik

@jtojnar
Copy link
Contributor

jtojnar commented Sep 4, 2023

I can reproduce it locally. Will try to debug it during the week.

@Art4 Art4 mentioned this pull request Sep 13, 2023
Draft
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Cache constantly updating
2 participants
@Art4 @jtojnar