Add HTTP layer to encapsulate SimplePie\File #758
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add a new layer for all HTTP requests to encapsulate the usage of the
SimplePie\File
.I propose this PR for SimplePie 1.8.0, see #731. This also refs #520.
I created the new
SimplePie\HTTP\Client
andSimplePie\HTTP\Response
interfaces inspired by PSR-18. Next I created the adapterSimplePie\HTTP\FileClient
to allow HTTP requests viaSimplePie\File
class. In a followup PR a new adapter will be possible to use a PSR-18 implementation directly.Encapsulate the usage of the
SimplePie\File
while keeping BC seems to be a complicated task. Therefor I've created this PR in an early draft stage. I invite everyone to give me early feedback.