Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of PSR-16 cache implementation #742

Merged
merged 21 commits into from
Oct 23, 2022

Conversation

Art4
Copy link
Contributor

@Art4 Art4 commented Aug 30, 2022

Hi 👋

this PR allows the usage of an extern PSR-16 cache implementation by registering a new cache type in Cache class.

I propose this feature for SimplePie 1.8.0, see roadmap #731.

Next steps could be to deprecate the usage of the internal cache solutions (mysql, file, redis, memcache and memcached) and remove them in v2 in favor of PSR-16.

@Art4 Art4 marked this pull request as draft August 30, 2022 08:48
@Art4 Art4 mentioned this pull request Aug 30, 2022
48 tasks
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chewed through the code and it looks good overall. I annotated the parts that made me scratch my head for a bit.

src/Cache/Psr16.php Outdated Show resolved Hide resolved
src/Cache/Psr16.php Show resolved Hide resolved
src/Cache/Psr16.php Outdated Show resolved Hide resolved
src/Cache/Psr16.php Outdated Show resolved Hide resolved
src/Cache/Psr16.php Show resolved Hide resolved
tests/Fixtures/FileMock.php Show resolved Hide resolved
tests/Unit/Cache/Psr16Test.php Outdated Show resolved Hide resolved
tests/Unit/Cache/Psr16Test.php Show resolved Hide resolved
tests/Unit/Cache/Psr16Test.php Outdated Show resolved Hide resolved
tests/Unit/Cache/Psr16Test.php Outdated Show resolved Hide resolved
@Art4 Art4 marked this pull request as ready for review October 10, 2022 14:11
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great.

@mblaney mblaney merged commit 2eaab53 into simplepie:master Oct 23, 2022
@Art4 Art4 deleted the allow-psr-16-cache branch October 23, 2022 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants