Feature/add ecs #182
Open
Feature/add ecs #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/collector/structs.go + AccountSpecifiedFiels struct to save AccountId and AccountName /collector/aws/common/structs.go + add Method getAccountName() /collector/aws/detector.go + save in DetectorManager the accountName from config file /collector/resources/* + save AccountSpecifiedFields with values in detectedStructs
… into feature_multi_account_selection
… into feature_multi_account_selection
Feature multi account selection
kaplanelad
reviewed
Aug 1, 2021
There was a problem hiding this comment.
Hey @daniebrill,
Thanks for adding EC@ resource!
This branch includes also the previews changes that have already been reviewed. for a better review, can you please merge the branch with feature/multi_account_selection ?
Feature/multi account selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Backend Feature
What this PR does / why we need it:
Add checks for ECS
Does this PR introduce a breaking change, if so what is it?:
Additional documentation: