Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add s3 #178

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Feature/add s3 #178

wants to merge 25 commits into from

Conversation

daniebrill
Copy link

What type of PR is this?
Backend Feature

What this PR does / why we need it:
Add checks for S3

Which issue(s) this PR fixes (if exists):

NONE

Additional documentation:

To check a bucket, you have to add a filter to this bucket:
Amazon S3 --> Bucket-name --> Metrics --> View additional charts --> Request metrics --> Manage filters --> Create filter

Filter name: EntireBucket
Scope: This filter applies to all objects in the bucket
--> Create filter

Jackafive753 and others added 24 commits May 28, 2021 14:10
@Jackafive753
#SOS-15
8daf59a 
/collector/structs.go
+ AccountSpecifiedFiels struct to save AccountId and AccountName

/collector/aws/common/structs.go
+ add Method getAccountName()

/collector/aws/detector.go
+ save in DetectorManager the accountName from config file

/collector/resources/*
+ save AccountSpecifiedFields with values in detectedStructs
@Jackafive753
#SOS-22
35a3f71 
* elasticsearch.go getDynamicMatchQuery
   add: if filterName is Data.AccountID then build boolQuery for given AccountIDs
@Jackafive753
#SOS-15
5866b6e 
fit MockAWSManager to the modified AWSManager
@daniebrill
#SOS-23 Add getAccounts + save account information in event_status
839ae2f
@daniebrill
#SOS-23 Use querylimit in aggregation + add error handling for type a…
6cd0a85 
…ssertion
@daniebrill
#SOS-23 Fix existing tests + code format
f8e931b
@daniebrill
#SOS-23 Modify GetAccounts for specific execution ID
259ccf7
@daniebrill
#SOS-23 Fit MockStorage to modified interface StorageDescriber
45db9b4
@daniebrill
#SOS-23 Add tests in interpolation_test.go and server_test.go
2f3c15c
@Jackafive753
#SOS-20
1fd641a 
* save arn in resourceID field
+ add values in test objects
@daniebrill
#SOS-23 Add test for elasticsearch GetAccounts
9c157f2
@Jackafive753
#SOS-16
0f68ad2 
+ add accounts to the provider store
+ Show Accounts in a chip-list like resources
+ add Accounts to filter
@Jackafive753
Merge remote-tracking branch 'origin/feature_multi_account_selection'…
2b48f30 
… into feature_multi_account_selection
@daniebrill
#SOS18 Add multiaccount selection functionality to tables
bf4c57d
@Jackafive753
#SOS-16
ecbe7ef 
add comments
@Jackafive753
Merge remote-tracking branch 'origin/feature_multi_account_selection'…
5a7065e 
… into feature_multi_account_selection
@Jackafive753
#SOS-18
5ea12e5 
add spentAccounts in summary
add things to success tests
@daniebrill
#SOS-18
2f99548 
Add multiaccount-selection functionality for RessourceCharts
@Jackafive753
Merge pull request #1 from evoila/feature_multi_account_selection
2c3e562 
Feature multi account selection
@florianbieser
#SOS-31
8416b89
@Jackafive753
#SOS-33
6f82820 
add S3 ("simple storage service") checks and test-file
change cloudwatch.go return error if no datapoint is returned from cloudwatch
@Jackafive753
fix warnings: unused statements
4df494c
@Jackafive753
# SOS-57
ab6405e 
remove account charts with not data found
@Jackafive753
set account to filters if an account specific Chart is clicked
f8adc70
kaplanelad
kaplanelad reviewed Aug 1, 2021
View reviewed changes
Copy link
Contributor

@kaplanelad kaplanelad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @daniebrill,

The new S3 resource is very useful.
this branch include also the previews changes that have already been reviewed. for better review, can you please merge the branch with feature/multi_account_selection ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaplanelad kaplanelad kaplanelad left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@daniebrill @kaplanelad @Jackafive753 @florianbieser