Enhanced Path Resolution for gcpCredentialsPath and ageKeyFile in getSopsGeneralOptions #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance the getSopsGeneralOptions function to properly handle file paths starting with '~' in both ageKeyFile and gcpCredentialsPath. This update allows these paths to be resolved to the user's home directory, improving usability and flexibility in path specification within sopsrc.
M1kep
force-pushed
the
fix/home-dir-tilde
branch
from
4046d61
to
42c6650
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates the
getSopsGeneralOptionsfunction to improve how paths are handled, specifically forgcpCredentialsPathandageKeyFile. The key enhancement is the ability to interpret and resolve paths starting with~, translating them to the user's home directory.Changes
Home Directory Path Expansion: The function now recognizes paths beginning with
~for bothgcpCredentialsPathandageKeyFile. It expands these paths to the user's home directory, enabling a more intuitive way for users to specify file locations.Path Normalization: The code uses
path.joinfor joining the home directory path with the rest of the path, ensuring correct formatting and resolution across different operating systems.Impact
This update simplifies path specification for users, allowing them to use the familiar ~ shorthand for the home directory.
It enhances the robustness of the function in handling different types of path inputs, improving the overall reliability of the extension.