Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): refactor #1239

Open
wants to merge 55 commits into
base: main
Choose a base branch
from
Open

docs(examples): refactor #1239

wants to merge 55 commits into from

Conversation

jul-lam
Copy link
Collaborator

@jul-lam jul-lam commented Apr 24, 2024

💡 What is the current behavior?

The examples are not consistent across the different frameworks, or missing.

JIRA Ticket: IX-1121
GitHub Issue Number: X

🆕 What is the new behavior?

Now, the examples are uniform, present in all frameworks, and have been reformatted.

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

X

@jul-lam jul-lam self-assigned this Apr 24, 2024
Copy link

changeset-bot bot commented Apr 24, 2024

⚠️ No Changeset found

Latest commit: 24e9ffa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jul-lam jul-lam marked this pull request as ready for review May 14, 2024 06:29
@jul-lam jul-lam marked this pull request as draft May 14, 2024 06:36
@jul-lam jul-lam marked this pull request as ready for review May 14, 2024 08:38
@jul-lam jul-lam requested a review from danielleroux May 14, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant