Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Card component #39

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Add Card component #39

merged 3 commits into from
Mar 22, 2024

Conversation

emncnozge
Copy link
Collaborator

@emncnozge emncnozge commented Mar 22, 2024

#36

Copy link
Contributor

@yagizhanNY yagizhanNY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check the comment? What do you think?

public partial class Card
{
[Parameter, EditorRequired]
public string Id { get; set; } = string.Empty;
Copy link
Contributor

@yagizhanNY yagizhanNY Mar 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The card component doesn't have an event, so the id property isn't required.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I removed the Id property.

@yagizhanNY yagizhanNY merged commit 52febcb into siemens:master Mar 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants