Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create failing test for https://github.com/sidorares/node-mysql2/issues/1847 #1899

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dsech
Copy link

@dsech dsech commented Mar 15, 2023

Fixes #1847

This PR contains just the failing test for #1847, without any fixes yet.

@dsech
Copy link
Author

dsech commented Mar 15, 2023

I need help with the test runner.

If I execute just this test locally, I get exit code 1, which is good, because the test is supposed to fail:

$ FILTER=test-query-stream-errors-propagation npm run test

> [email protected] test
> node ./test/run.js

[0:00:00 1 0/1 100.0% node test/integration/connection/test-query-stream-errors-propagation.mjs]
About to exit with code: 1

But if I execute all tests with npm run test then I get exit code 0, which doesn't seem right, because the new test is supposed to fail.

I need some help debugging this problem with the test runner first.

Nevermind, the default regex used by urun did not include mjs files. Updated the regex and now the new test is failing in CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection errors are not propagated to the query stream
1 participant