Keyword Helpful Hints #2587
Open
Keyword Helpful Hints #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bill-shuup
force-pushed
the
keywords-hints
branch
from
b136065
to
f931006
Compare
Codecov Report
@@ Coverage Diff @@
## master #2587 +/- ##
=======================================
Coverage 87.77% 87.77%
=======================================
Files 894 894
Lines 40407 40407
Branches 5272 5272
=======================================
Hits 35467 35467
Misses 3721 3721
Partials 1219 1219
Continue to review full report at Codecov.
|
chessbr
suggested changes
Aug 12, 2021
| @@ -90,7 +90,7 @@ class Meta: | |||
| "variation_name", | |||
| ) | |||
| widgets = { | |||
| "keywords": forms.TextInput(), | |||
| "keywords": forms.TextInput(attrs={"placeholder": "EXAMPLE: cotton, wool, clothing, ..."}), | |||
There was a problem hiding this comment.
make this be a translated string: _("Example: cotton, wool...")
There was a problem hiding this comment.
Yeah, I thought of that last night. I need to train myself to think more internationally by default.
bill-shuup
force-pushed
the
keywords-hints
branch
from
f931006
to
28f76c5
Compare
chessbr
reviewed
Aug 12, 2021
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ('shuup', '0095_reindex_catalog'), |
There was a problem hiding this comment.
please rebase with master as this is not the correcy dependency anymore :D
Add information to the help text and placeholder text that make it more clear keywords should be comma separated. Reference: https://trello.com/c/lWeCtNjN/65-new-fb-keyword-alter-help-text
bill-shuup
force-pushed
the
keywords-hints
branch
from
28f76c5
to
9ea3557
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add information to the help text and placeholder text that make it more clear keywords should be comma separated.
Reference: https://trello.com/c/lWeCtNjN/65-new-fb-keyword-alter-help-text