fix: include the base domain shuttleapp.rs in the wildcard certificate #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Hi @paulotten, would you be interested in continuing on this? It has been left stale due to the base name not being very important, but I can see how having a nice landing page or redirect to the main website has value. |
|
Hi @jonaro00, my dance card is full until the new year. Feel free to take over on this if you wish. From my recollection I thought these current changes should be sufficient to get the wildcard certificate working also for the base domain. I never managed to properly test that however. @iulianbarbu had some feedback on how to do this on issue #833. I forget exactly where I ran into problems. Once the certificate is working for the base domain I imagine adding a redirect would be trivial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #833
Description of change
TODO
How has this been tested? (if applicable)
TODO