Fix ESM build to contain import statements with full file extensions
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which is compatible with the Node version 16.14.0 that's used in the meantime
shtaif
force-pushed
the
fix-esm-build-import-file-extensions
branch
from
2232136
to
43f4ac7
Compare
shtaif
changed the title
imports statements with full file extensionsimport statements with full file extensions
shtaif
pushed a commit
that referenced
this pull request
Jun 22, 2024
## [1.2.5](v1.2.4...v1.2.5) (2024-06-22) ### Bug Fixes * fix ESM build to contain `import` statements with full file extensions ([#49](#49)) ([2aad91d](2aad91d)) ### Refactor * internal logic fix in the multicast channel code (no public behavior impact) - ensure to mark a channel's iterator as closed for further pull attempts as soon as it realizes its parent channel itself had already ended/errored out ([#47](#47)) ([d11a74b](d11a74b)) ### Tests * split the single current test file into two - one having all the tests relevant only for the `iterified` function and the other all the tests relevant only for `iterifiedUnwrapped` ([#48](#48)) ([815d357](815d357))
|
🎉 This PR is included in version 1.2.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, the what used to be built into the
./dist/esm;iterified/tsconfig-esm.json
Line 5 in 815d357
seems to not have actually been 100% proper ESM code, if not outright invalid, since all the generated import statements appearing in the output files did not include fully qualified file paths including the file extension.
This should make all built output contain fully qualified import file paths (including the CJS build, harmlessly).
Set the pnpm version that's installed during CI to a fixed earlier
pnpm^8one since the latest is not compatible with the old Node 16 that's used across the CI (which should be tackled separately in some future PR).Also some TypeScript-related improvements which should make IDE detect the tsconfig better and also load a proper tsconfig configuration for the files in
./specdir which I suspect I couldn't do up until now.