Internal code refactoring #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s that happen across mainly `createMulticastChannel.ts` and `iterified.ts`
shtaif
pushed a commit
that referenced
this pull request
Sep 29, 2023
## [1.2.4](v1.2.3...v1.2.4) (2023-09-29) ### Refactor * internal code refactoring to simplify and untangle a bit the processes that happen across mainly `createMulticastChannel.ts` and `iterified.ts` ([#43](#43)) ([cc8f333](cc8f333)) ### Tests * edit test titles' wording ([#42](#42)) ([d636e3a](d636e3a)) ### Documentation * edit and add some more JSDocs ([#46](#46)) ([a7141ec](a7141ec)) * small assorted edits across `README.md` ([#45](#45)) ([ec15cde](ec15cde))
|
🎉 This PR is included in version 1.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal code refactoring to simplify and untangle a bit the processes that happen across mainly
createMulticastChannel.tsanditerified.ts:iterified.ts- attempt to make the code flow revolve as much as possible around the generator code + other various simplifications.createMulticastChannel.ts- remove the apparently-unnecessarymakeCallableOnceAtATimewrapper for thenextmethod (since its overall logic seemed to achieve the once-at-a-time effect by itself already), convert the individual pending pulls awaiting logic from the style of a "subscriptionMapthat holds deferreds" to a simpler kinda more natural "shared deferred local iterator deferreds" + other various simplifications.