Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing violation snippet for email at path /account/register #3714

Closed
wants to merge 1 commit into from

Conversation

cramytech
Copy link
Contributor

1. Why is this change necessary?

translation for error.VIOLATION::INVALID_FORMAT_ERROR is missing.

2. What does this change do, exactly?

add translation in the en-GB and de-DE snippets.

3. Describe each step to reproduce the issue or behaviour.

enter x@x as email at path /account/register

4. Please link to the relevant issues (if any).

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@CLAassistant
Copy link

CLAassistant commented May 14, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Warnings
⚠️ The Pull Request doesn't contain any changelog file

@shopware-github-importer
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-36145

Please use this issue to track the state of your pull request.

@mstegmeyer
Copy link
Contributor

Hey, thank you for you contribution and congratulations to your first PR. Great to meet you at the Hackathon and I hope, you had fun at the SCD as well. 💙🎉

@wannevancamp
Copy link
Contributor

@mstegmeyer , I saw this PR passing. We had a similar same issue. I don't think this solution is correct. This error can be thrown in different places and is not immediately related to email validation.

@mstegmeyer
Copy link
Contributor

@wannevancamp you're right, email should probably just be input. I will fix it quickly 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants