Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT-00000 - Activate headless sales channel without a theme #3709

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

sobyte
Copy link
Contributor

@sobyte sobyte commented May 13, 2024

1. Why is this change necessary?

See #3474

2. What does this change do, exactly?

Add condition to activation toggle to exclude headless sales channels.

3. Describe each step to reproduce the issue or behaviour.

See #3474

4. Please link to the relevant issues (if any).

#3474

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@CLAassistant
Copy link

CLAassistant commented May 13, 2024

CLA assistant check
All committers have signed the CLA.

@marcelbrode
Copy link
Contributor

LGTM 👍

@sobyte Would you mind adding a jest test case for that? 😄

@marcelbrode
Copy link
Contributor

Hi there. 2 Weeks have passed, anything new here? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants