NEXT-00000 - Do not add promotion when cart price is zero

[jasperP98]

1. Why is this change necessary?

When a promotion is added to a cart with a total price of zero, there will be an error thrown. This error is thrown for auto promotions or regular promotions.

2. What does this change do, exactly?

This change adds an extra check and does not process the discounts when the total price of the cart is zero.

3. Describe each step to reproduce the issue or behaviour.

1. Add a product with price 0
2. Add discount via auto promo or via normal promo code
3. A 500 error is thrown

4. Please link to the relevant issues (if any).

/

5. Checklist

• I have rebased my changes to remove merge conflicts
• I have written tests and verified that they fail without my change
• I have created a changelog file with all necessary information about my changes
• I have written or adjusted the documentation according to my changes
• This change has comments for package types, values, functions, and non-obvious lines of code
• I have read the contribution requirements and fulfil them.

[github-actions]

	Warnings
⚠️	Please be kind and add unit tests for your new code in these files: src/Core/Checkout/Promotion/Cart/Error/PromotionsOnCartPriceZeroError.php If you are sure everything is fine with your changes, you can resolve this warning. You can run `composer make:coverage` to generate dummy unit tests for files that are not covered

[AydinHassan]

hey @jasperP98 how does it work when you refresh? Does the error keep persisting? Or are the items removed?

[jasperP98]

Hi @AydinHassan The items can not be persisted to the cart for auto promotions since the recalculation progress will throw a 500 error. When you try to add a discount code, this will throw an error when adding the discount, so after refresh the line item will still be in the cart. I made a quick video to show the behavior: https://drive.google.com/drive/folders/1D5l2eI9d4HKAo_K-jzHx6uvxPZIjTQpe?usp=sharing

[AydinHassan]

@jasperP98 got it, thanks! Makes sense to me. The assigned team will take care of the PR soon :)

[shopware-github-importer]

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-36151

Please use this issue to track the state of your pull request.

[jasperP98]

Hi @marcelbrode! I see that i missed a translation for my cart error. I will add this ASAP

[marcelbrode]

Hi @marcelbrode! I see that i missed a translation for my cart error. I will add this ASAP

Hey @jasperP98! Nice catch! Lookin forward to your push 👍

[marcelbrode]

Oh, @jasperP98 and when, you're at it: A Unit test would be great 😄

[marcelbrode]

Your Pull Request has been merged! 🎉
Thanks for your contribution! 💙