Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT-36018 - refactor: Unify SendMailAction constants #3694

Closed

Conversation

aragon999
Copy link
Contributor

1. Why is this change necessary?

Currently there are a duplicated constants, and when developing I was unsure which ones to use.

2. What does this change do, exactly?

Unify the constants and deprecate accordingly.

3. Describe each step to reproduce the issue or behaviour.

Develop something with mail attachments or mail actions.

4. Please link to the relevant issues (if any).

-

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@aragon999 aragon999 force-pushed the refactor/unify-send-mail-constants branch from f213f70 to be5a432 Compare May 2, 2024 11:55
@aragon999 aragon999 force-pushed the refactor/unify-send-mail-constants branch from be5a432 to c564b69 Compare May 2, 2024 12:16
@jozsefdamokos jozsefdamokos self-assigned this May 7, 2024
@shopware-github-importer shopware-github-importer bot changed the title NEXT-0000: refactor: Unify SendMailAction constants NEXT-36049 - NEXT-0000: refactor: Unify SendMailAction constants May 7, 2024
@jozsefdamokos jozsefdamokos changed the title NEXT-36049 - NEXT-0000: refactor: Unify SendMailAction constants NEXT-36018 - refactor: Unify SendMailAction constants May 7, 2024
@jozsefdamokos
Copy link
Member

@aragon999 thanks for your contribution!

@aragon999 aragon999 deleted the refactor/unify-send-mail-constants branch May 17, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants