Refactor Code to Improve Code Quality by Removing Implementation and Design Smells #1007
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Following Type Of Refactoring were applied to remove code smells and improve code quality :
Implementation Smell Refactoring :
1). Decompose Conditional
sm-core/src/main/java/com/salesmanager/core/business/repositories/catalog/product
ProductRepositoryImpl
listByStore
2). Extract Method
sm-shop/src/main/java/com/salesmanager/shop/store/controller/shoppingCart.facade
ShoppingCartFacadeImpl
getByCode
3). Rename Variable
sm-core/src/main/java/com/salesmanager/core/business/utils
ProductPriceUtils
getFinalPrice
Design Smell Refactoring :
1). Extract Class
sm-core-model/src/main/java/com/storemanager/core/model/common
Criteria
2). Move Method
sm-core/src/main/java/com/salesmanager/core/business/services/search
SearchServiceImpl
Config
3). Pull Up Variable
sm-core/src/main/java/com/salesmanager/core/business/modules/integration/shipping/impl
CustomWeightBasedShippingQuote