Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Code to Improve Code Quality by Removing Implementation and Design Smells #1007

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

LuvPatel
Copy link

The Following Type Of Refactoring were applied to remove code smells and improve code quality :



Implementation Smell Refactoring :

1). Decompose Conditional

  • Path : sm-core/src/main/java/com/salesmanager/core/business/repositories/catalog/product
  • Class : ProductRepositoryImpl
  • Method : listByStore

2). Extract Method

  • Path : sm-shop/src/main/java/com/salesmanager/shop/store/controller/shoppingCart.facade
  • Class: ShoppingCartFacadeImpl
  • Method : getByCode

3). Rename Variable

  • Path : sm-core/src/main/java/com/salesmanager/core/business/utils
  • Class: ProductPriceUtils
  • Method : getFinalPrice



Design Smell Refactoring :

1). Extract Class

  • Path : sm-core-model/src/main/java/com/storemanager/core/model/common
  • Class : Criteria

2). Move Method

  • Path : sm-core/src/main/java/com/salesmanager/core/business/services/search
  • Class : SearchServiceImpl
  • Method : Config

3). Pull Up Variable

  • Path : sm-core/src/main/java/com/salesmanager/core/business/modules/integration/shipping/impl
  • Class : CustomWeightBasedShippingQuote

Copy link

sonarcloud bot commented Mar 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant