Add support for sl-dropdown in the default slot of sl-breadcrumb-item #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
schilchSICKAG
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to add
<sl-dropdown>in the default slot of a<sl-breadcrumb-item>as requested and discussed in #2011, this feature.The following changes where made to make this work:
The
rendercall does not rely on thehrefattribute alone to render. Instead, a new staterenderTypeis created that may hold one of the following values:'button' | 'link' | 'drop-down'. As before, it defaults tobutton, making all original examples work.A
slotChangelistener is bound to all default slots that checks for availability of a slotted<sl-dropdown>. If one is found, the render type is set todrop-down. In all other cases, the logic from the original rendering applies.I also have added tests and updated the documentation. However, I am unsure how to document this. Should we leave the initial example as is or create a new one (which I did in this PR)?
Looking forward to your suggestions.