James/en/992 #1467
Merged
James/en/992 #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When utilizing the Modal dialog box Entity Reference type, the modal buttons persistently display even when the Show Modal Buttons option is set to false. Similarly, the modal buttons continue to appear when Allow New Record is enabled on the Entity picker.
Steps to reproduce the behavior:
Navigate to 'https://function-adminportal-test.shesha.dev/dynamic/Boxfusion.SheshaFunctionalTests.Common/book-twenty-two'
Click on 'Add'
Open form designer mode.
Drag and drop an Entity Picker component and configure it.
Enable the Allow New Record option.
Ensure that Show Modal Buttons is set to false.
Save and render the form.
Click on the Entity Picker and select the Add New button.
Observe that the modal buttons persist despite the Show Modal Buttons setting.
Similarly, within the details form, add a new Entity Reference and select the modal box dialog entity type.
Do not select the Show Modal Buttons option.
Save and render the form.
Observe that the modal buttons still display.
Expected behavior
When Show Modal Buttons are set to false or when Allow New Record is enabled without the modal buttons option selected, the modal buttons should not appear in the Entity Picker or Entity Reference modal dialog.