Prepare PyProject for PyPi #2116
Merged
+57
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdushantha
force-pushed
the
feature/pyproject
branch
from
b27ca92
to
1698928
Compare
sdushantha
approved these changes
May 11, 2024
|
This PR breaks compatibility with the When a Python project is packaged, it will only load Try installing the current Sherlock in a clean virtual environment with: pip install git+https://github.com/sherlock-project/sherlock.gitThen run: sherlock ppfeister --site GitHub --localYou will get the error: ERROR: Problem while attempting to access data file '/home/<user>/<project-dir>/.venv/lib/python3.11/site-packages/resources/data.json'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2036
Closes #2017
Related to #2111 (possible switch to poetry)