Add maximum worker control #2070
Open
+14
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Argument --max-workers is added to Sherlock, default 20, allowing the user to specify the maximum number of workers. If the sitelist is lower than the maximum, it will not create more workers than sites.
ppfeister
changed the title
ppfeister
changed the title
ppfeister
force-pushed
the
feature/workerctl
branch
from
2d53367
to
9128e40
Compare
ppfeister
force-pushed
the
feature/workerctl
branch
from
9128e40
to
7c2c2ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2059
Argument
--workersis added to Sherlock, default 20, allowing the user to specify the maximum number of workers. If the target list is shorter than the maximum, it will not create more workers than targets. No upper limit applied to argument, but the value should be type safe.Validated with values both higher and lower than the default.
On most capable machines, the bottleneck is the response time of individual targets rather than process time. This can't help very much with response time.
It does allow you to better control worker count in very-low-power situations or in those that have consistently delayed results (to avoid stacked delays). Users using
--torwould likely see the most benefit, since those loading times can stack.Discretionary feature PR